dApp staking v3 precompile docs #1121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dinonard
added
documentation
Dinonard
requested review from
shaunxw,
ashutoshvarma,
PierreOssun and
andabak
ashutoshvarma
previously approved these changes
Jan 3, 2024
|
|
||
| Some examples of this: | ||
| * Since all stakes are reset at the end of each period, developers will need to adapt their smart contract logic for this. | ||
| * Bonus rewards concept was only introduced from the precompile v2 interface, so there's no equivalent call in v1 interface. |
There was a problem hiding this comment.
I know, but it's kind of confusing with the v1,v2 versioning for precompile and v2,v3 for pallet 😅
There was a problem hiding this comment.
How about I rename the .sol interfaces to v2 and v3?
There was a problem hiding this comment.
That would make more sense and less confusing.
ashutoshvarma
approved these changes
Jan 3, 2024
Minimum allowed line rate is |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Summary
Extended documentation about dApp staking precompile v2 & v3 interface differences.